Skip to content

Add bidder params and debug helpers to openrtb request #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ChristianPavilonis wants to merge 2 commits into
base: fix/proxy-compression-issues
Choose a base branch
from
Open

Add bidder params and debug helpers to openrtb request #172

ChristianPavilonis wants to merge 2 commits into from

Conversation

@ChristianPavilonis
Copy link
Collaborator

@ChristianPavilonis ChristianPavilonis commented Jan 14, 2026 •
edited
Loading

Waiting until #147 is merged.

aram356
aram356 requested changes Jan 15, 2026
View reviewed changes
crates/common/src/integrations/prebid.rs Outdated
}));
}

// Parse bids from query parameter if present
Copy link
Collaborator

@aram356 aram356 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I know this is draft but can we finally move to specific structs.

@aram356 aram356 linked an issue Jan 19, 2026 that may be closed by this pull request
As publisher I want to use Kargo SSP through Prebid server #130
Open
@ChristianPavilonis ChristianPavilonis force-pushed the feature/kargo-integration branch 2 times, most recently from fbae661 to 1f11d06 Compare January 20, 2026 21:51
@ChristianPavilonis ChristianPavilonis changed the base branch from main to fix/proxy-compression-issues January 20, 2026 21:51
@ChristianPavilonis ChristianPavilonis force-pushed the feature/kargo-integration branch 2 times, most recently from 1543ff3 to dac30b3 Compare January 21, 2026 01:28
@ChristianPavilonis ChristianPavilonis force-pushed the feature/kargo-integration branch from dac30b3 to d199f21 Compare January 21, 2026 15:43
@ChristianPavilonis ChristianPavilonis force-pushed the fix/proxy-compression-issues branch from 9de521a to d0b99c1 Compare January 21, 2026 15:43
@ChristianPavilonis ChristianPavilonis marked this pull request as ready for review January 21, 2026 15:43
aram356
aram356 requested changes Jan 22, 2026
View reviewed changes
Copy link
Collaborator

@aram356 aram356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some opportunity to improve it.

@ChristianPavilonis
clean up
a8b5337 
- use concrete types for openrtb
- clean up duplicate code
- removed log statements
- adds fallback for empty bidders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aram356 aram356 Awaiting requested review from aram356

Assignees

@ChristianPavilonis ChristianPavilonis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

As publisher I want to use Kargo SSP through Prebid server

3 participants

@ChristianPavilonis @aram356